netdev - Re: [IPV6]: Do not set IF_READY if device is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070327213032.GA30935@gondor.apana.org.au>
Date:	Wed, 28 Mar 2007 07:30:32 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [IPV6]: Do not set IF_READY if device is down

On Tue, Mar 27, 2007 at 02:57:18PM +0100, David Woodhouse wrote:
>
> >     [IPV6]: Do not set IF_READY if device is down
> >     
> >     Now that we add the IPv6 device at registration time we don't need
> >     to set IF_READY in ipv6_add_dev anymore because we will always get
> >     a NETDEV_UP event later on should the device ever become ready.
> >     
> >     Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> >     Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> This commit seems to have broken NetworkManager, which removes the
> link-local IPv6 address from each wireless interface while it's only
> intending to use it for scanning, then adds it back when it actually
> wants to _use_ the interface in question.

Sorry, that patch is indeed broken.  We do need to set IF_READY in
the case where all addresses were deleted (including the link-local)
and then recreated.  The IPv6 device will be destroyed and recreated
too in that case.

[IPV6]: Set IF_READY if the device is up and has carrier

We still need to set the IF_READY flag in ipv6_add_dev for the case
where all addresses (including the link-local) are deleted and then
recreated.  In that case the IPv6 device too will be destroyed and
then recreated.

In order to prevent the original problem, we simply ensure that
the device is up before setting IF_READY.

Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 1b61699..7552663 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -342,6 +342,9 @@ static struct inet6_dev * ipv6_add_dev(struct net_device *dev)
 	}
 #endif
 
+	if (netif_running(dev) && netif_carrier_ok(dev))
+		ndev->if_flags |= IF_READY;
+
 	ipv6_mc_init_dev(ndev);
 	ndev->tstamp = jiffies;
 #ifdef CONFIG_SYSCTL
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html