netdev - Re: [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460A08E2.4080904@garzik.org>
Date:	Wed, 28 Mar 2007 02:19:14 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dale Farnsworth <dale@...nsworth.org>
CC:	Gabriel Paubert <paubert@...m.es>,
	Manish Lachwani <mlachwani@...sta.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field

Dale Farnsworth wrote:
> From: Gabriel Paubert <paubert@...m.es>
> 
> In this driver, the default ethernet address is first set by by calling
> eth_port_uc_addr_get() which reads the relevant registers of the
> corresponding port as initially set by firmware. However that function
> used the port_num field accessed through the private area of net_dev
> before it was set.
> 
> The result was that one board I have ended up with the unicast address
> set to 00:00:00:00:00:00 (only port 1 is connected on this board). The
> problem appeared after commit 84dd619e4dc3b0b1c40dafd98c90fd950bce7bc5.
> 
> This patch fixes the bug by setting mp->port_num prior to calling
> eth_port_uc_get_addr().
> 
> Signed-off-by: Gabriel Paubert <paubert@...m.es>
> Signed-off-by: Dale Farnsworth <dale@...nsworth.org>
> ---

applied #1 to upstream-fixes


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html