netdev - Re: [1/1] netlink: no need to crash if table does not exist.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070328084306.GB28242@2ka.mipt.ru>
Date:	Wed, 28 Mar 2007 12:43:06 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Miller <davem@...emloft.net>
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [1/1] netlink: no need to crash if table does not exist.

On Tue, Mar 27, 2007 at 04:41:54PM -0700, David Miller (davem@...emloft.net) wrote:
> > There is no problem as-is, but I implement unified cache for different
> > sockets (currently tcp/udp/raw and netlink are supported), which does
> > not use that table, so I currently wrap all access code into special
> > ifdefs, this one can be wrapped too, but since it is not needed, it
> > saves couple of lines of code.
> 
> It is needed.  It is there to make sure that a kernel netlink
> socket is not created before the af_netlink init code runs.
> 
> We've had sequencing bugs like that in the initcall call chain
> in the past, that's why the check is there.

Argh, I see.
I fail to find exact commit (at least it was not in 2.4 and was created
before 2.6.12), but it is ineed neeed.

Thanks for explaination.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html