netdev - Re: KERNEL: assertion ((int)tp->sacked_out >= 0) failed at net/ipv4/tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070328.120604.38712657.davem@davemloft.net>
Date:	Wed, 28 Mar 2007 12:06:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: KERNEL: assertion ((int)tp->sacked_out >= 0) failed at
 net/ipv4/tcp_input.c (2626)

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Wed, 28 Mar 2007 16:24:40 +0300 (EEST)

> It seems I'm being guilty to this one, Dave please apply to net-2.6.22 
> (besides this I think the tcp_sync_left_out should be changed but I'll 
> prepare a patch for that later). Btw, how should this kind of email with 
> some non-patch description+patch be formatted?).

Thanks for figuring out the problem so quickly, this formatting
is fine.

> [PATCH] [TCP]: Timedout loop must skip SACKed skbs too while marking
> 
> Marking skb with both S and L is invalid, and that could easily
> happen in the timedout loop. Later on the tcp_sync_left_out
> reduces sacked_out if lost_out + sacked_out > packets_out and
> then eventually sacked_out underflows triggering a debug trap in
> tcp_clean_rtx_queue.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Patch applied, thanks a lot!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html