netdev - [PATCH][IPv6]: Fix incorrect length check in rawv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1175203048.16183.14.camel@w-sridhar2.beaverton.ibm.com>
Date:	Thu, 29 Mar 2007 14:17:28 -0700
From:	Sridhar Samudrala <sri@...ibm.com>
To:	davem@...emloft.net, yoshfuji@...ux-ipv6.org
Cc:	netdev@...r.kernel.org
Subject: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

The check for length in rawv6_sendmsg() is incorrect.
As len is an unsigned int, (len < 0) will never be TRUE.
I think checking for IPV6_MAXPLEN(65535) is better.

Is it possible to send ipv6 jumbo packets using raw
sockets? If so, we can remove this check.

Thanks
Sridhar

Signed-off-by: Sridhar Samudrala <sri@...ibm.com>

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 306d5d8..dc11ec3 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -686,10 +686,7 @@ static int rawv6_sendmsg(struct kiocb *i
 	u16 proto;
 	int err;
 
-	/* Rough check on arithmetic overflow,
-	   better check is made in ip6_build_xmit
-	 */
-	if (len < 0)
+	if (len > IPV6_MAXPLEN)
 		return -EMSGSIZE;
 
 	/* Mirror BSD error message compatibility */


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html