lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Mar 2007 09:32:17 +0200 (CEST) From: Guennadi Liakhovetski <gl@...-ac.de> To: Jeff Garzik <jeff@...zik.org> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Samuel Ortiz <samuel@...tiz.org> Subject: Re: [git patches] net driver fixes On Thu, 29 Mar 2007, Jeff Garzik wrote: > Guennadi Liakhovetski wrote: >> Jeff, might be worth getting the sk_buff leak fix in ppp from >> http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too? >> >> Don't know how important it is for stable. It was present in 2.6.18 too. > > Can you resend the patch to me, please? > > Easier for the system to apply than the URL... Sure, attached below. I think, though, this patch is already in someone's tree. Andrew has applied it to -mm under the name ppp-dont-leak-an-sk_buff-on-interface-destruction.patch but then dropped with the reasoning "This patch was dropped because it was merged into mainline or a subsystem tree". So, maybe it is now in Samuel's IrDA tree. Samuel?So, maybe all you have to do is to pull it from his tree. Thanks Guennadi --------------------------------- Guennadi Liakhovetski, Ph.D. DSA Daten- und Systemtechnik GmbH Pascalstr. 28 D-52076 Aachen Germany Don't leak an sk_buff on interface destruction. Signed-off-by: G. Liakhovetski <gl@...-ac.de> --- a/drivers/net/ppp_generic.c 2007-03-23 13:04:04.000000000 +0100 +++ b/drivers/net/ppp_generic.c 2007-03-23 13:05:29.000000000 +0100 @@ -2544,6 +2544,9 @@ ppp->active_filter = NULL; #endif /* CONFIG_PPP_FILTER */ + if (ppp->xmit_pending) + kfree_skb(ppp->xmit_pending); + kfree(ppp); } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists