netdev - [PATCH] Ensure local assignment bit on tun device MAC addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1175302152.12230.414.camel@localhost.localdomain>
Date:	Sat, 31 Mar 2007 10:49:12 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: [PATCH] Ensure local assignment bit on tun device MAC addr

This becomes especially important after the tun patch sitting in the -mm
tree is applied, but it works standalone.  Please apply.  (See netdev
posting Message-Id: <200703270550.l2R5o0Mh008378@...ll0.pdx.osdl.net>)

==
The effect of this bug was made worse by Brian Braunstein's patch to keep
net_device.dev_addr and tun.dev_addr in sync.

Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff -r fd8c40f4f533 drivers/net/tun.c
--- a/drivers/net/tun.c	Fri Mar 30 17:02:19 2007 +1000
+++ b/drivers/net/tun.c	Sat Mar 31 10:30:47 2007 +1000
@@ -507,9 +507,7 @@ static int tun_set_iff(struct file *file
 		tun->flags = flags;
 		/* Be promiscuous by default to maintain previous behaviour. */
 		tun->if_flags = IFF_PROMISC;
-		/* Generate random Ethernet address. */
-		*(u16 *)tun->dev_addr = htons(0x00FF);
-		get_random_bytes(tun->dev_addr + sizeof(u16), 4);
+		random_ether_addr(tun->dev_addr);
 		memset(tun->chr_filter, 0, sizeof tun->chr_filter);

 		tun_net_init(dev);

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html