netdev - Re: [PATCH 2.6.21-rc5] b44: fix IFF_ALLMULTI handling of CAM slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1175526669.3035.3.camel@dhcp-10-12-136-115.broadcom.com>
Date:	Mon, 02 Apr 2007 08:11:09 -0700
From:	"Gary Zambrano" <zambrano@...adcom.com>
To:	"Bill Helfinstine" <bhelf@...tterfly.whirpon.com>
cc:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.21-rc5] b44: fix IFF_ALLMULTI handling of CAM
 slots

On Sun, 2007-04-01 at 10:10 -0700, Bill Helfinstine wrote:
> 
> If you set the IFF_ALLMULTI flag on a b44 device, or if you join more
> than
> B44_MCAST_TABLE_SIZE multicast groups, the device will stop receiving
> unicast
> messages.  This is because the __b44_set_mac_addr call sets the zeroth
> CAM
> entry to the MAC address of the device, and then the loop at line 1722
> proceeds to overwrite it unless the value of i is set by the
> __b44_load_mcast
> call.  However, when IFF_ALLMULTI is set, that call is bypassed,
> leaving i set
> to zero. 
> 
> Fixed by starting the loop at 1 to make it skip the CAM entry for the
> MAC
> address.
> 
> Signed-off-by: Bill Helfinstine <bhelf@...tterfly.whirpon.com>

Thanks.

Acked-by: Gary Zambrano <zambrano@...adcom.com>


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html