lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Apr 2007 14:37:01 -0700 From: "Michael Chan" <mchan@...adcom.com> To: "Gagan Arneja" <gaagaan@...il.com> cc: netdev@...r.kernel.org Subject: Re: tg3 reset_task question On Wed, 2007-04-04 at 13:34 -0700, Gagan Arneja wrote: > Can't this BUG_ON be hit very easily: > > static void tg3_irq_quiesce(struct tg3 *tp) > { > BUG_ON(tp->irq_sync); > ... > } > > tg3_reset_task could easily be racing with another thread, that calls > tg3_full_lock(tp, 1); e.g tg3_change_mtu. Maybe I'm missing something > obvious. > Yes, you're right. Perhaps we should get the rtnl first before tg3_full_lock(), or turn irq_sync into an atomic counter that allows nesting. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists