netdev - Re: [PATCH 1/4] [IPv6] Add link and site-local scope inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Apr 2007 02:37:52 -0400
From:	Brian Haley <brian.haley@...com>
To:	YOSHIFUJI Hideaki / ???? 
	<yoshfuji@...ux-ipv6.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, dccp@...r.kernel.org,
	lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH 1/4] [IPv6] Add link and site-local scope inline



YOSHIFUJI Hideaki / ???? wrote:
> In article <4615BCA1.6000608@...com> (at Thu, 05 Apr 2007 23:21:05 -0400), Brian Haley <brian.haley@...com> says:
> 
>> Add link and site-local scope inline to avoid calls to ipv6_addr_type().
>>
> 
> I disagree.  Multicast scopes should also be handled appropriately.

Yes, I totally missed that 
ipv6_addr_scope2type(IPV6_ADDR_MC_SCOPE(addr)) in __ipv6_addr_type(), so 
the linklocal inline probably isn't worth it since it would have to be 
something like:

static inline int ipv6_addr_scope_linklocal(const struct in6_addr *a)
{
return ((a->s6_addr32[0] & htonl(0xFFC00000)) == htonl(0xFE800000) ||
         ((a->s6_addr32[0] & htonl(0xFF000000)) == htonl(0xFF000000) &&
          ((a)->s6_addr[1] & 0x0f) == IPV6_ADDR_SCOPE_LINKLOCAL)))
}

That's not that clean an inline anymore, but still doable...

I'll clean-up the rest based on your comments and re-send.

-Brian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html