lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 Apr 2007 11:48:32 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: sshtylyov@...mvista.com (Sergei Shtylyov) Cc: jgarzik@...ox.com, netdev@...r.kernel.org, mhuth@...sta.com, kgdb-bugreport@...ts.sourceforge.net Subject: Re: [PATCH] 8139too: harden against TX ring overflow Sergei Shtylyov <sshtylyov@...mvista.com> wrote: > This driver's 4-packet deep TX queue is too sensible to the "careless" callers > ignoring its state (like netpoll in trapped mode), so add "queue full" check at > the start of the hard_start_xmit() method (only under #ifndef RTL8139_NDEBUG, > otherwise the queue will get stuck once dirty pointer gets out of sync); switch > to using appropriate mnemonics for the return values while at it. Could you please describe this netpoll scenario in more detail? More importantly, why wouldn't we fix netpoll instead? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists