netdev - Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070409.114323.78734391.davem@davemloft.net>
Date:	Mon, 09 Apr 2007 11:43:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bryan.wu@...log.com
Cc:	alan@...rguk.ukuu.org.uk, waltje@...lt.NL.Mugnet.ORG,
	aubreylee@...il.com, netdev@...r.kernel.org, akpm@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

From: David Miller <davem@...emloft.net>
Date: Mon, 09 Apr 2007 09:55:23 -0700 (PDT)

> From: "Wu, Bryan" <bryan.wu@...log.com>
> Date: Mon, 09 Apr 2007 17:50:22 +0800
> 
> > On Mon, 2007-04-09 at 11:01 +0800, Aubrey Li wrote:
> > > The option CONFIG_PACKET_MMAP should depend on MMU.
> > > 
> > > Signed-off-by: Aubrey.Li <aubreylee@...il.com>
> > > ---
> > >  net/packet/Kconfig |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/net/packet/Kconfig b/net/packet/Kconfig
> > > index 34ff93f..959c272 100644
> > > --- a/net/packet/Kconfig
> > > +++ b/net/packet/Kconfig
> > > @@ -17,7 +17,7 @@ config PACKET
> > > 
> > >  config PACKET_MMAP
> > >  	bool "Packet socket: mmapped IO"
> > > -	depends on PACKET
> > > +	depends on PACKET && MMU
> > >  	help
> > >  	  If you say Y here, the Packet protocol driver will use an IO
> > >  	  mechanism that results in faster communication.
> > 
> > Yeah, this is a bug found on blackfin arch and it is also for other
> > NOMMU arch. Is there any solution for this? We think Aubrey's idea
> > works.
> 
> I will apply this patch.

Actually I won't, the other comments in this thread make a lot
of sense, we should try to make it build and work just as we
do for other similar things on no-MMU.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html