netdev - Re: [PATCH 2/2] NET: Multiqueue network device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070409.134631.71091422.davem@davemloft.net>
Date:	Mon, 09 Apr 2007 13:46:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jgarzik@...ox.com, cramerj@...el.com, auke-jan.h.kok@...el.com,
	christopher.leech@...el.com
Subject: Re: [PATCH 2/2] NET: Multiqueue network device support.

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Mon, 9 Apr 2007 13:43:11 -0700

> True, but the assignment for "dev" above also casts this void * to
> struct net_device *:
> 
>         dev = (struct net_device *)
>                 (((long)p + NETDEV_ALIGN_CONST) & ~NETDEV_ALIGN_CONST);
>         dev->padded = (char *)dev - (char *)p;
> 
> Shall I remove my cast?

I think so.  Casts tend to be red flags during patch review,
so don't add them when not necessary and let's remove the
unnecessary ones too.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html