netdev - Re: [PATCH 1/4] skge: turn carrier off when down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Apr 2007 11:54:54 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] skge: turn carrier off when down

Stephen Hemminger wrote:
> Driver needs to turn off carrier when down, otherwise it can
> confuse bonding and bridging and looks like carrier is on immediately
> when it is brought back up.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>
> 
> --- netdev-2.6.orig/drivers/net/skge.c	2007-04-07 15:09:13.000000000 -0700
> +++ netdev-2.6/drivers/net/skge.c	2007-04-07 15:09:58.000000000 -0700
> @@ -2535,6 +2535,7 @@
>  		printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
>  
>  	netif_stop_queue(dev);
> +	netif_carrier_off(dev);
>  	if (hw->chip_id == CHIP_ID_GENESIS && hw->phy_type == SK_PHY_XMAC)
>  		del_timer_sync(&skge->link_timer);
>  
> 


applied 1-4


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html