netdev - Re: [Bugme-new] [Bug 8320] New: replacing route in kernel doesn't send netlink message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070411094740.e7c04b49.akpm@linux-foundation.org>
Date:	Wed, 11 Apr 2007 09:47:40 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	milan.kocian@...cz
Cc:	netdev@...r.kernel.org,
	"bugme-daemon@...nel-bugs.osdl.org" 
	<bugme-daemon@...zilla.kernel.org>
Subject: Re: [Bugme-new] [Bug 8320] New: replacing route in kernel doesn't
 send netlink message

On Wed, 11 Apr 2007 02:37:01 -0700 bugme-daemon@...zilla.kernel.org wrote:

> 
> http://bugzilla.kernel.org/show_bug.cgi?id=8320
> 
>            Summary: replacing route in kernel doesn't send netlink message
>     Kernel Version: 2.6.20.6
>             Status: NEW
>           Severity: low
>              Owner: shemminger@...l.org
>          Submitter: milan.kocian@...cz
> 
> 
> Most recent kernel where this bug did *NOT* occur: I think all 2.6 kernels
> Distribution: Debian (with vanilla kernel)
> Hardware Environment: PC
> Software Environment: Debian
> Problem Description:
> When you replace route (via ip r r ), no netlink message is sent. Or is it feature?
> 
> Steps to reproduce:
> 1. run 'ip monitor all' on one console
> 2. do 'ip r r EXISTING_ROUTE via DST' on second console
> 3. no message on console one
> 
> Small patch for fib_hash (tested) but use carefully I am newbie :-) :
> 
> --- fib_hash.c.old      2007-04-11 10:39:34.895667672 +0200
> +++ fib_hash.c  2007-04-11 10:41:34.623466280 +0200
> @@ -457,6 +457,8 @@
>                         fib_release_info(fi_drop);
>                         if (state & FA_S_ACCESSED)
>                                 rt_cache_flush(-1);
> +                       rtmsg_fib(RTM_NEWROUTE, key, fa, cfg->fc_dst_len, tb->tb_id,
> +                                 &cfg->fc_nlinfo);
>                         return 0;
>                 }
> 
> And for fib_trie (not tested):
> 
> --- fib_trie.c.old      2007-04-11 10:39:22.728517360 +0200
> +++ fib_trie.c  2007-04-11 10:40:40.778651936 +0200
> @@ -1205,6 +1205,8 @@
>                         fib_release_info(fi_drop);
>                         if (state & FA_S_ACCESSED)
>                                 rt_cache_flush(-1);
> +                       rtmsg_fib(RTM_NEWROUTE, htonl(key), new_fa, plen, tb->tb_id,
> +                                 &cfg->fc_nlinfo);
> 
>                         goto succeeded;
>                 }

Thanks.  We prefer to receive patches via email rather than via bugzilla. 
But that's a relatively minor matter - let's see what the net guys think
about the change first ;)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html