netdev - udp checksum issue in netpoll mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d6a94c50704120331m36957148iae111ab7324c88c2@mail.gmail.com>
Date:	Thu, 12 Apr 2007 18:31:30 +0800
From:	"Aubrey Li" <aubreylee@...il.com>
To:	"Stephen Hemminger" <shemminger@...l.org>,
	"Herbert Xu" <herbert@...dor.apana.org.au>,
	"Matt Mackall" <mpm@...enic.com>
Cc:	netdev@...r.kernel.org,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: udp checksum issue in netpoll mode.

I think we discussed this issue before.

The current checksum function doesn't consider the kind of packet
which is padded to reach a specific minimum length. I believe that's
the problem caused my test case failed. Is this issue fixed? Or is it
acceptable if I make a patch not calculating this kind of packet?

Thanks,
-Aubrey
===============================================
static __sum16 checksum_udp(struct sk_buff *skb, struct udphdr *uh,
                            unsigned short ulen, __be32 saddr, __be32 daddr)
{
        __wsum psum;

        if (uh->check == 0 || skb->ip_summed == CHECKSUM_UNNECESSARY)
                return 0;

        psum = csum_tcpudp_nofold(saddr, daddr, ulen, IPPROTO_UDP, 0);
        if (skb->ip_summed == CHECKSUM_COMPLETE &&
            !csum_fold(csum_add(psum, skb->csum)))
                return 0;

        skb->csum = psum;

        return __skb_checksum_complete(skb);
}
===============================================
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html