netdev - Re: Fw: [PATCH] allow VLAN interface on top of bridge interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461EA863.9020702@candelatech.com>
Date:	Thu, 12 Apr 2007 14:45:07 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	netdev@...r.kernel.org, Jerome Borsboom <j.borsboom@...smusmc.nl>
Subject: Re: Fw: [PATCH] allow VLAN interface on top of bridge interface

Andrew Morton wrote:
> 
> Begin forwarded message:
> 
> Date: Thu, 12 Apr 2007 21:50:00 +0200 (CEST)
> From: Jerome Borsboom <j.borsboom@...smusmc.nl>
> To: linux-kernel@...r.kernel.org
> Subject: [PATCH] allow VLAN interface on top of bridge interface
> 
> 
> When a VLAN interface is created on top of a bridge interface and 
> netfilter is enabled to see the bridged packets, the packets can be 
> corrupted when passing through the netfilter code. This is caused by the 
> VLAN driver not setting the 'protocol' and 'nh' members of the sk_buff 
> structure. In general, this is no problem as the VLAN interface is mostly 
> connected to a physical ethernet interface which does not use the 
> 'protocol' and 'nh' members. For a bridge interface, however, these 
> members do matter.

Why only do this inside that if clause?  I can see only setting
nh.raw in that clause, but it seems like the protocol should be set
regardless.

Thanks,
Ben


> 
> Signed-off-by: Jerome Borsboom <j.borsboom@...smusmc.nl>
> 
> 
> --- linux-2.6.20/net/8021q/vlan_dev.c 2007-02-04 19:44:54.000000000 +0100 
> +++ linux-2.6.20/net/8021q/vlan_dev.c 2007-04-12 21:12:17.000000000 +0200 
> @@ -380,6 +380,9 @@
>   		} else {
>   			vhdr->h_vlan_encapsulated_proto = htons(len);
>   		}
> +
> +		skb->protocol = htons(ETH_P_8021Q);
> +		skb->nh.raw = skb->data;
>   	}
> 
>   	/* Before delegating work to the lower layer, enter our MAC-address */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html