netdev - Re: [PATCH] allow VLAN interface on top of bridge interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070412.150105.45898545.davem@davemloft.net>
Date:	Thu, 12 Apr 2007 15:01:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	greearb@...delatech.com
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	j.borsboom@...smusmc.nl
Subject: Re: [PATCH] allow VLAN interface on top of bridge interface

From: Ben Greear <greearb@...delatech.com>
Date: Thu, 12 Apr 2007 14:45:07 -0700

> Andrew Morton wrote:
> > 
> > Begin forwarded message:
> > 
> > Date: Thu, 12 Apr 2007 21:50:00 +0200 (CEST)
> > From: Jerome Borsboom <j.borsboom@...smusmc.nl>
> > To: linux-kernel@...r.kernel.org
> > Subject: [PATCH] allow VLAN interface on top of bridge interface
> > 
> > 
> > When a VLAN interface is created on top of a bridge interface and 
> > netfilter is enabled to see the bridged packets, the packets can be 
> > corrupted when passing through the netfilter code. This is caused by the 
> > VLAN driver not setting the 'protocol' and 'nh' members of the sk_buff 
> > structure. In general, this is no problem as the VLAN interface is mostly 
> > connected to a physical ethernet interface which does not use the 
> > 'protocol' and 'nh' members. For a bridge interface, however, these 
> > members do matter.
> 
> Why only do this inside that if clause?  I can see only setting
> nh.raw in that clause, but it seems like the protocol should be set
> regardless.

Because outside the if clause we are making the packet look
like a normal ethernet frame to the rest of the stack, and
only adding the VLAN tag at the very last moment in
->hard_start_xmit().
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html