[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070413.223739.27452745.davem@davemloft.net>
Date: Fri, 13 Apr 2007 22:37:39 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: dada1@...mosbay.com
Cc: herbert@...dor.apana.org.au, danielschaffrath@....com,
greearb@...delatech.com, andi@...stfloor.org,
netdev@...r.kernel.org, bcrl@...ck.org
Subject: Re: TCP connection stops after high load.
From: Eric Dumazet <dada1@...mosbay.com>
Date: Sat, 14 Apr 2007 07:31:35 +0200
> When did tg3 model changed exactly ?
June of 2006:
commit 00b7050426da8e7e58c889c5c80a19920d2d41b3
Author: Michael Chan <mchan@...adcom.com>
Date: Sat Jun 17 21:58:45 2006 -0700
[TG3]: Convert to non-LLTX
Herbert Xu pointed out that it is unsafe to call netif_tx_disable()
from LLTX drivers because it uses dev->xmit_lock to synchronize
whereas LLTX drivers use private locks.
Convert tg3 to non-LLTX to fix this issue. tg3 is a lockless driver
where hard_start_xmit and tx completion handling can run concurrently
under normal conditions. A tx_lock is only needed to prevent
netif_stop_queue and netif_wake_queue race condtions when the queue
is full.
So whether we use LLTX or non-LLTX, it makes practically no
difference.
Signed-off-by: Michael Chan <mchan@...adcom.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists