netdev - Re: [NET]: Get rid of alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2007 12:29:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	hch@...radead.org, netdev@...r.kernel.org, keir@...source.com
Subject: Re: [NET]: Get rid of alloc_skb code duplication

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 18 Apr 2007 00:17:43 +1000

> On Tue, Apr 17, 2007 at 02:03:47PM +0100, Christoph Hellwig wrote:
> >
> > It was put in for Xen, but if you as the resident beat the crap out
> > of Xen networking guru don't know about it we should probably just
> > kill it.  Especially as we usually kill dead code pretty fast.
> 
> Heh, I wasn't touching Xen back then.
> 
> That's good news actually.  Xen has now killed their custom alloc_skb
> so this is no longer needed.  Besides, even if they needed it they'll
> have to patch it in anyway since you've already killed the ifdef that
> lets them have a custom alloc_skb :)
> 
> [NET]: Get rid of alloc_skb_from_cache
> 
> Since this was added originally for Xen, and Xen has recently (~2.6.18)
> stopped using this function, we can safely get rid of it.  Good timing
> too since this function has started to bit rot.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied.  You missed the arch/x86_64/kernel/functionlist reference
but I took care of that for you :-)

I'm going to push this into 2.6.21 because the sooner this dies
the better, even though it will make for some net-2.6.22 merge
hassles for me.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html