netdev - Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070418.012804.95897126.davem@davemloft.net>
Date:	Wed, 18 Apr 2007 01:28:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...ru
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	bridge@...ts.osdl.org, devel@...nvz.org
Subject: Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet
 addresses

From: Pavel Emelianov <xemul@...ru>
Date: Wed, 18 Apr 2007 10:43:56 +0400

> [snip]
> 
> > --- linux-2.6.orig/net/bridge/br_private.h	2007-04-17
> > 13:26:48.000000000 -0700 +++ linux-2.6/net/bridge/br_private.h
> > 2007-04-17 13:30:29.000000000 -0700 @@ -36,7 +36,7 @@
> >  {
> >  	unsigned char	prio[2];
> >  	unsigned char	addr[6];
> > -};
> > +} __attribute__((aligned(8)));
> 
> Why "8"? Mustn't it be "16"? Address is to be 2-bytes aligned...

Actually it could be made "2", the aligned() attribute is
in bytes, not bits.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html