netdev - Re: [PATCH] [net-2.6] IrDA: Correctly handling socket error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070418.150756.122832779.davem@davemloft.net>
Date:	Wed, 18 Apr 2007 15:07:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	samuel@...tiz.org
Cc:	netdev@...r.kernel.org, irda-users@...ts.sourceforge.net,
	olaf.kirch@...cle.com, stable@...nel.org
Subject: Re: [PATCH] [net-2.6] IrDA: Correctly handling socket error

From: Samuel Ortiz <samuel@...tiz.org>
Date: Thu, 19 Apr 2007 00:45:26 +0300

> From: Olaf Kirch <olaf.kirch@...cle.com>
> 
> This patch fixes an oops first reported in mid 2006 - see
> http://lkml.org/lkml/2006/8/29/358 The cause of this bug report is that
> when an error is signalled on the socket, irda_recvmsg_stream returns
> without removing a local wait_queue variable from the socket's sk_sleep
> queue. This causes havoc further down the road.
> 
> In response to this problem, a patch was made that invoked sock_orphan on
> the socket when receiving a disconnect indication. This is not a good fix,
> as this sets sk_sleep to NULL, causing applications sleeping in recvmsg
> (and other places) to oops.
> 
> This is against the latest net-2.6 and should be considered for -stable
> inclusion. 
> 
> Signed-off-by: Olaf Kirch <olaf.kirch@...cle.com>
> Signed-off-by: Samuel Ortiz <samuel@...tiz.org>

Applied and I'll push this to -stable too, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html