lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Apr 2007 11:41:45 -0400 From: Jeff Garzik <jeff@...zik.org> To: Neil Horman <nhorman@...driver.com> CC: netdev@...r.kernel.org, davem@...emloft.net, venza@...wnhat.org Subject: Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation Neil Horman wrote: > Hey there- > The sis900 driver appears to have a bug in which the receive routine > passes the skbuff holding the received frame to the network stack before > refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the > driver simply leaves a hole in the rx ring, which causes the driver to stop > receiving frames and become non-recoverable without an rmmod/insmod according to > reporters. This patch reverses that order, attempting to allocate a replacement > buffer first, and receiving the new frame only if one can be allocated. If no > skbuff can be allocated, the current skbuf in the rx ring is recycled, dropping > the current frame, but keeping the NIC operational. > > Thanks & Regards > Neil > > Signed-off-by: Neil Horman <nhorman@...driver.com> Please CC the net driver maintainer ;-) I'll queue this for review. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists