netdev - Re: is CONFIG_NET_CLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97949e3e0704231608n6f43807en1ee6e27265c641ba@mail.gmail.com>
Date:	Mon, 23 Apr 2007 16:08:37 -0700
From:	"Laurent Chavey" <chavey@...gle.com>
To:	hadi@...erus.ca
Cc:	netdev@...r.kernel.org
Subject: Re: is CONFIG_NET_CLS_ACT always set ?

sorry for the trick question.

I was simply making a modification to the skb tap code
to allow tcpdump to work on the slave interface and not
just the bonded one. The code change requires a change to
the for loop code and it follow on to the call to deliver_skb().

In the process of adding the code, I noticed that if (at least
that is how I read the code)
CONFIG_NET_CLS_ACT is not defined then
the last pt_prev is call after the diverter and bridge code
have handled the skb.  This would only occur for bridged skb
that one wanted to tap.

On 4/23/07, jamal <hadi@...erus.ca> wrote:
> On Mon, 2007-23-04 at 14:19 -0700, Laurent Chavey wrote:
> > if CONFIG_NET_CLS_ACT is not defined, then is the
> > code below correct ?
>
> The simple answer is yes;
> Is something not working for you?
>
> It is hard to read your question my good friend because it comes out
> like a trick question;->
> It is more useful to say:
>  "I think this code is broken because ...."
> And even more useful if you add:
> "I have run the following testcases to illustrate blah ..."
> Then if something is broken, and you want to be popular, you say:
> "netdevers, heres the fix"
>
> Anyways, what is the problem?
>
> cheers,
> jamal
>
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html