lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Apr 2007 13:55:40 +0100 From: James Chapman <jchapman@...alix.com> To: netdev@...r.kernel.org Subject: [PATCH 0/5 2.6.21-rc7] l2tp: introduce PPP over L2TP driver This patch set adds a driver for PPP over L2TP. Patches to follow. The following changes have been made since the previous version submitted 23-MAR-07, addressing review comments received so far:- - Fold makefile changes into the patches that add new source files. - Make API structures 64-bit safe by avoiding holes inserted by the compiler for field alignment. - Fix list locking. - Use inlines rather than macros for obtaining local context pointers. (Previous code obscured use of variables and labels in macros.) - Use endian-annotated types where appropriate. - Use skb_queue_walk() for walking skb lists. - Add check that session doesn't already exist before allowing it to be created. - Remove unnecessary try_module_get() / put_module() calls. - No need to check for NULL before calling kfree(). - Use macros in jiffies.h for time/jiffy conversion. - Minimize size of L2TP's private data that is stored in skb->cb[]. - Change transmit path to build UDP header locally and transmit using ip_queue_xmit() rather than use the UDP socket's sendmsg(). This change also avoids the use of a kernel thread to do the transmit. - Fix seq file code to avoid potential buffer overflow when there are lots of tunnels/sessions. - Fix some socket refcount/lock bugs. Fixes derived from recent pppoe patches. The implementation uses the existing PPPoX subsystem that is currently used only by PPPoE. A userspace daemon handles all L2TP control protocol messages, while a PPPoX socket carries user data. The system architecture is similar to PPPoE, where a pppd plugin uses the PPPoX socket to send/receive PPP frames over an L2TP tunnel. PPP control frames are delivered to pppd while data frames are handled entirely by the kernel. There are 5 patches in the series:- 1 - pppol2tp driver core. New code. Requires patches 2 & 3. 2 - API changes for L2TP. Adds definitions for L2TP in existing headers. 3 - Introduce skb_queue_walk_safe() macro. 4 - Change to PPPoX core to allow PPPoX protocol modules such as pppol2tp to be autoloaded via modprobe.conf. 5 - Adds an entry to MAINTAINERS file. The driver is being used on x86, ia64, ppc, arm, mips32 and possibly other architectures. It is also known to work on multi-core SMP boxes. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists