netdev - Re: net-2.6.22 UDP stalls/hangs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070423.170700.122831331.davem@davemloft.net>
Date:	Mon, 23 Apr 2007 17:07:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org, acme@...hat.com
Subject: Re: net-2.6.22 UDP stalls/hangs

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 24 Apr 2007 10:04:58 +1000

> On Mon, Apr 23, 2007 at 03:45:09PM -0700, David Miller wrote:
> > 
> > Either that or some error in Herbert's recent checksum offload
> > handling changes, such as, in fact I am highly suspicious of
> > the second change listed below, you may want to try reverting
> > just that one:
> 
> Indeed.  My change depended on drivers correctly using csum_offset
> instead of the old csum field.  That was wrong anyway since sparse
> would now warn against that usage.  However, prior to my change it
> was harmless.
> 
> [NETDRV]: Perform missing csum_offset conversions
> 
> When csum_offset was introduced we did a conversion from csum to
> csum_offset where applicable.  A couple of drivers were missed in
> this process.
> 
> It was harmless to begin with since the two fields coincided.  Now
> that we've made them different with the addition of csum_start, the
> missed drivers must be converted or they can't send packets out at
> all that require checksum offload.
>      
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks a lot Herbert.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html