netdev - Re: [net-2.6.22] [TCP]: Fix linkage errors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Apr 2007 18:38:27 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	YOSHIFUJI Hideaki / ____________ 
	<yoshfuji@...ux-ipv6.org>
Cc:	bunk@...sta.de, davem@...emloft.net, shemminger@...l.org,
	netdev@...r.kernel.org, tglx@...utronix.de
Subject: Re: [net-2.6.22] [TCP]: Fix linkage errors.

On Wed, 25 Apr 2007 01:10:28 +0900 (JST)
YOSHIFUJI Hideaki  <yoshfuji@...ux-ipv6.org> wrote:

> How about this?
> 
>  
> +static inline s64 ktime_to_us(const ktime_t kt)
> +{
> +	struct timeval tv = ktime_to_timeval(kt);
> +	return tv.tv_sec * USEC_PER_SEC + tv.tv_usec;
> +}
> +

Well, I am afraid it's not 100% correct.

If you really want to return s64 you should do

return (s64) tv.tv_sec * USEC_PER_SEC + tv.tv_usec;

But then it might be overkill to compute a full s64 for TCP use, since we use u32 vrtt

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html