netdev - Re: [net-2.6.22] [IPV4]: Fix build without procfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070425.114650.93714393.yoshfuji@linux-ipv6.org>
Date:	Wed, 25 Apr 2007 11:46:50 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	herbert@...dor.apana.org.au
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [net-2.6.22] [IPV4]: Fix build without procfs.

Hello.

In article <E1HgXMD-0000LK-00@...dolin.me.apana.org.au> (at Wed, 25 Apr 2007 12:35:49 +1000), Herbert Xu <herbert@...dor.apana.org.au> says:

> This makes no sense.  Why should we include all these proc operations
> when PROC_FS is turned off? How about this as a fix (on top of the
> above patch):
> 
> [IPV4]: Move snmp_mib_init out of proc.c
> 
> The function snmp_mib_init has nothing to do with proc so this patch
> moves it out of proc.c and to the only place that uses it.  Right now
> there is only one user so I'ved made it static too.

Herbert, as I said before, we could defer that.
It was preparation for future development (per-interface statistics
and netlink interface.
(I would say, proc.c should be snmp.c.)

Regards,

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html