netdev - Re: [Fwd: [PATCH] [TIPC]: Enhancements to msg_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200704251839.44056.netdev@axxeo.de>
Date:	Wed, 25 Apr 2007 18:39:43 +0200
From:	Ingo Oeser <netdev@...eo.de>
To:	Jon Paul Maloy <jon.maloy@...csson.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Per Liden <per.liden@...csson.com>,
	"Stephens, Allan" <allan.stephens@...driver.com>
Subject: Re: [Fwd: [PATCH] [TIPC]: Enhancements to msg_set_bits() routine]

Hi Jon,

Jon Paul Maloy schrieb:
> 2) The code has been optimized to minimize the number of run-time
>    endianness conversion operations by leveraging the fact that the
>    mask (and, in some cases, the value as well) is constant and the
>    necessary conversion can be performed by the compiler.

3) It can be checked by sparse, if you use proper types.
 
> diff --git a/net/tipc/msg.h b/net/tipc/msg.h
> index 62d5490..5c64e55 100644
> --- a/net/tipc/msg.h
> +++ b/net/tipc/msg.h
> @@ -71,8 +71,11 @@ static inline void msg_set_word(struct tipc_msg *m, u32
> w, u32 val) static inline void msg_set_bits(struct tipc_msg *m, u32 w,
>  				u32 pos, u32 mask, u32 val)

static inlinevoid msg_set_bits(struct tipc_msg *m, u32 w,
  				u32 pos, __be32 mask, __be32 val)


Care to resubmit?


Best Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html