netdev - Re: [PATCH 3/9] wext: remove dead debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2007 09:46:32 -0700
From:	Jean Tourrilhes <jt@....hp.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 3/9] wext: remove dead debug code

On Tue, Apr 24, 2007 at 08:07:35PM +0200, Johannes Berg wrote:
> This patch kills a whole bunch of code that can only ever be used by
> defining some things in wext.c. Also, the things that are printed are
> mostly useless since the API is fairly well-tested.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

	Hi,

	Overall ok with the patches. Comments on a few of them...
	I personally would not remove this DEBUG code, because it
decreases the overall maitainability of the code.
	First, it does not only help to debug the API, but it can be
used to debug userspace and drivers in some extreme cases.
	Second, this debugging act as documentation. He points out
which are the important variables and how they are used at critical
points of the code.
	As this debug is localised, and compiled out, it does not
bother anybody and should stay.

	Regards,

	Jean
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html