netdev - Re: [PATCH 7/9] wext: reduce inline abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1177607646.6814.106.camel@johannes.berg>
Date:	Thu, 26 Apr 2007 19:14:05 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	jt@....hp.com
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 7/9] wext: reduce inline abuse

On Thu, 2007-04-26 at 09:50 -0700, Jean Tourrilhes wrote:

> 	That's clearly not true of all compilers. All gcc versions
> before 4.0 need serious help to inline functions used only once. Our
> current minimal requirement for the kernel is gcc 3.2, therefore this
> code is still useful.
> 	Note that this is a legitimate use of inline (tell the
> compiler to inline the function), not an abuse.

No, the abuse is using inline in the first place because it doesn't
matter, none of this has an actual reason to be inlined.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)