netdev - Re: very strange inet_sock corruption with rpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39e6f6c70704260600n1cd879e7u6a284b1235425db3@mail.gmail.com>
Date:	Thu, 26 Apr 2007 10:00:50 -0300
From:	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
To:	"Olaf Kirch" <okir@....de>
Cc:	"Vlad Yasevich" <vladislav.yasevich@...com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: very strange inet_sock corruption with rpc

On 4/26/07, Olaf Kirch <okir@....de> wrote:
> On Wednesday 25 April 2007 23:03, Vlad Yasevich wrote:
> > It looks like someone is stepping all over the inet_sock.
> > We'll continue looking, but if anyone has any ideas of what might
> > be going on, I'd appreciate it.
>
> This could be a socket in TIME_WAIT. A socket entering
> TIME_WAIT will be replaced by an inet_timewait_sock, which is
> a kind of truncated inet_sock.

I bet it is, as all the members that are touched without checking if
it is a TIME_WAIT sockets are in the common part, struct sock_common,
and things like inet_v6_ipv6only() and inet_rcv_saddr() check if it is
a TIME_WAIT socket.

So please do this check:

if (sk->sk_state != TCP_TIME_WAIT)

before testing the new fields in inet_sock :-)

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html