netdev - Re: [PATCH 00/14] AF_RXRPC socket family and AFS rewrite [net-2.6]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070426.200809.04441500.davem@davemloft.net>
Date:	Thu, 26 Apr 2007 20:08:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dhowells@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 00/14] AF_RXRPC socket family and AFS rewrite [net-2.6]

From: David Miller <davem@...emloft.net>
Date: Thu, 26 Apr 2007 16:15:22 -0700 (PDT)

> Ok, I applied it all and added a compiler warning fix for 64-bit
> at the end.

I just found a problem in your work, you cannot use cmpxchg() in
generic code, it is not available on all processors:

davem@...set:~/src/GIT/net-2.6$ egrep cmpxchg fs/afs/*.c
fs/afs/vlocation.c:			if (cmpxchg(&vl->state, state, AFS_VL_CREATING) ==
davem@...set:~/src/GIT/net-2.6$ 

Also, cmpxchg() implementations typically only support 32-bit and
64-bit atomic operations, so even if this were allowed you'll get
linking errors on sparc64 (and I think powerpc):

WARNING: "__cmpxchg_called_with_bad_pointer" [fs/afs/kafs.ko] undefined!
make[1]: *** [__modpost] Error 1

Anyways, please get me a patch to fix this, use a spinlock or
the existing vl->lock rwlock.  Something like that.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html