lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Apr 2007 20:20:37 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dhowells@...hat.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH 00/14] AF_RXRPC socket family and AFS rewrite [net-2.6] From: David Miller <davem@...emloft.net> Date: Thu, 26 Apr 2007 20:12:13 -0700 (PDT) > And even more problems, what the heck are you doing here? And even more: commit 68c708fd5e90f6d178c84bb7e641589eb2842319 Author: David S. Miller <davem@...set.davemloft.net> Date: Thu Apr 26 20:20:21 2007 -0700 [RXRPC]: Fix pointers passed to bitops. CC [M] net/rxrpc/ar-input.o net/rxrpc/ar-input.c: In function .$,1rx.(Brxrpc_fast_process_data.$,1ry.(B: net/rxrpc/ar-input.c:171: warning: passing argument 2 of .$,1rx.(B__test_and_set_bit.$,1ry.(B from incompatible pointer type net/rxrpc/ar-input.c:180: warning: passing argument 2 of .$,1rx.(B__clear_bit.$,1ry.(B from incompatible pointer type net/rxrpc/ar-input.c:218: warning: passing argument 2 of .$,1rx.(B__clear_bit.$,1ry.(B from incompatible pointer type Signed-off-by: David S. Miller <davem@...emloft.net> diff --git a/net/rxrpc/ar-input.c b/net/rxrpc/ar-input.c index ceb5d61..91b5bbb 100644 --- a/net/rxrpc/ar-input.c +++ b/net/rxrpc/ar-input.c @@ -168,7 +168,7 @@ static int rxrpc_fast_process_data(struct rxrpc_call *call, /* we may already have the packet in the out of sequence queue */ ackbit = seq - (call->rx_data_eaten + 1); ASSERTCMP(ackbit, >=, 0); - if (__test_and_set_bit(ackbit, &call->ackr_window)) { + if (__test_and_set_bit(ackbit, call->ackr_window)) { _debug("dup oos #%u [%u,%u]", seq, call->rx_data_eaten, call->rx_data_post); ack = RXRPC_ACK_DUPLICATE; @@ -177,7 +177,7 @@ static int rxrpc_fast_process_data(struct rxrpc_call *call, if (seq >= call->ackr_win_top) { _debug("exceed #%u [%u]", seq, call->ackr_win_top); - __clear_bit(ackbit, &call->ackr_window); + __clear_bit(ackbit, call->ackr_window); ack = RXRPC_ACK_EXCEEDS_WINDOW; goto discard_and_ack; } @@ -215,7 +215,7 @@ static int rxrpc_fast_process_data(struct rxrpc_call *call, ret = rxrpc_queue_rcv_skb(call, skb, false, terminal); if (ret < 0) { if (ret == -ENOMEM || ret == -ENOBUFS) { - __clear_bit(ackbit, &call->ackr_window); + __clear_bit(ackbit, call->ackr_window); ack = RXRPC_ACK_NOSPACE; goto discard_and_ack; } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists