lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Apr 2007 11:17:57 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Greg KH <greg@...ah.com> Cc: ???????????? <yoshfuji@...ux-ipv6.org>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, stable@...nel.org Subject: Re: [stable] [PATCH] ipv6: track device renames in snmp6 That patch I sent was against 2.6.21, but both 2.6.20 and 2.6.21 have the problem. Here is a version for 2.6.20. ============================================= When network device's are renamed, the IPV6 snmp6 code gets confused. It doesn't track name changes so it will OOPS when network device's are removed. The fix is trivial, just unregister/re-register in notify handler. Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org> --- net/ipv6/addrconf.c | 6 ++++-- net/ipv6/proc.c | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) --- linux-2.6.20.y.orig/net/ipv6/addrconf.c 2007-04-27 11:14:51.000000000 -0700 +++ linux-2.6.20.y/net/ipv6/addrconf.c 2007-04-27 11:16:26.000000000 -0700 @@ -2338,8 +2338,9 @@ static int addrconf_notify(struct notifi break; case NETDEV_CHANGENAME: -#ifdef CONFIG_SYSCTL if (idev) { + snmp6_unregister_dev(idev); +#ifdef CONFIG_SYSCTL addrconf_sysctl_unregister(&idev->cnf); neigh_sysctl_unregister(idev->nd_parms); neigh_sysctl_register(dev, idev->nd_parms, @@ -2347,8 +2348,9 @@ static int addrconf_notify(struct notifi &ndisc_ifinfo_sysctl_change, NULL); addrconf_sysctl_register(idev, &idev->cnf); - } #endif + snmp6_register_dev(idev); + } break; }; --- linux-2.6.20.y.orig/net/ipv6/proc.c 2007-02-23 15:34:07.000000000 -0800 +++ linux-2.6.20.y/net/ipv6/proc.c 2007-04-27 11:16:26.000000000 -0700 @@ -237,6 +237,7 @@ int snmp6_unregister_dev(struct inet6_de return -EINVAL; remove_proc_entry(idev->stats.proc_dir_entry->name, proc_net_devsnmp6); + idev->stats.proc_dir_entry = NULL; return 0; } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists