lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 28 Apr 2007 15:52:46 +1000
From:	Herbert Xu <>
To:	Rusty Russell <>
Cc:	"David S. Miller" <>,,
	Jeff Garzik <>,
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS

On Sat, Apr 28, 2007 at 03:46:01PM +1000, Rusty Russell wrote:
> OK, I did a quick check, and the only one I could find was br_if.c which
> calls register_netdevice() and doesn't set get_stats.  I don't think
> that zeroes in this case matters.

Thanks for following up on this Rusty!

Actually I just had a look at br_if.c and it seems that it does set
get_stats through br_dev_setup to br_dev_get_stats.

> ==
> Remove NETIF_F_INTERNAL_STATS: default to internal stats.
> Herbert Xu conviced me that a new flag was overkill; every driver
> currently overrides get_stats, so we might as well make the internal
> one the default.  If someone did fail to set get_stats, they would now
> get all 0 stats instead of "No statistics available".
> Signed-off-by: Rusty Russell <>

Looks good to me.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists