netdev - Re: [PATCH repost] netpoll: trapping fix/cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070428130055.GW11115@waste.org>
Date:	Sat, 28 Apr 2007 08:00:55 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	shemminger@...ux-foundation.org
Subject: Re: [PATCH repost] netpoll: trapping fix/cleanup

On Sat, Apr 28, 2007 at 04:56:23PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> Matt Mackall wrote:
> 
> >>CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely 
> >>bypassed in
> >>the netpoll's "trapped" mode which easily causes overflows in the drivers 
> >>with
> >>short TX queues (most notably, in 8139too with its 4-deep queue).
> >>Make this option more sensible by only bypassing TX softirq wakeup and 
> >>remove
> >>CONFIG_NETPOLL_RX option completely since there is *no* code depending on 
> >>it.
> 
> >You've got two unrelated patches here, so that's an automatic NAK.
> 
>   Come on, killing a long ago no-op option doesn't worth the sepearte 
>   patch. :-)
> 
> >I suppose we can kill the config option.
> 
>   I've even posted the refs to the commits introducing and killing the 
>   #ifdef's.
> 
> >What did you test the NETPOLL_TRAP test with?
> 
>   KGDBoE (and maybe also netconsole -- don't remember already).

Ok, KGDBoE is a pretty good test here. Netconsole isn't.

Please resend as two separate patches and add:

Acked-by: Matt Mackall <mpm@...enic.com>

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html