netdev - Re: [PATCH 1/3] ne: Add platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070429.014026.25926525.anemo@mba.ocn.ne.jp>
Date:	Sun, 29 Apr 2007 01:40:26 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	akpm@...ux-foundation.org
Cc:	linux-mips@...ux-mips.org, netdev@...r.kernel.org, jeff@...zik.org,
	ralf@...ux-mips.org, sshtylyov@...mvista.com
Subject: Re: [PATCH 1/3] ne: Add platform_driver

On Sat, 28 Apr 2007 00:57:27 -0700, Andrew Morton <akpm@...ux-foundation.org> wrote:
> > +#else /* MODULE */
> > +module_init(ne_init);
> > +module_exit(ne_exit);
> >  #endif /* MODULE */
> 
> Are we sure about this part?  It is unusual to have special treatment dependent
> upon MODULE.

Yes, it is unusual now, but ne.c has old-fashioned init_module() which
can not be used if it was built into kernel.  Also ne.c depends on
old-style initialization by Space.c.

Rewriting those old-style initialization code could be possible, but
it will involve much more changes and might cause compatibility issue
(if somebody depends on ethN order of built-in drivers).  So I chose
least intrusive way.

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html