lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 28 Apr 2007 18:24:36 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, venza@...wnhat.org
Subject: Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

> >diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c
> >index a6a0f09..7e44939 100644
> >--- a/drivers/net/sis900.c
> >+++ b/drivers/net/sis900.c
> >@@ -1754,6 +1754,7 @@ static int sis900_rx(struct net_device *net_dev)
> > 			sis_priv->rx_ring[entry].cmdsts = RX_BUF_SIZE;
> > 		} else {
> > 			struct sk_buff * skb;
> >+			struct sk_buff * rx_skb;
> > 
> > 			pci_unmap_single(sis_priv->pci_dev,
> > 				sis_priv->rx_ring[entry].bufptr, RX_BUF_SIZE,
> >@@ -1787,10 +1788,10 @@ static int sis900_rx(struct net_device *net_dev)
> > 			}
> > 
> > 			/* give the socket buffer to upper layers */
> >-			skb = sis_priv->rx_skbuff[entry];
> >-			skb_put(skb, rx_size);
> >-			skb->protocol = eth_type_trans(skb, net_dev);
> >-			netif_rx(skb);
> >+			rx_skb = sis_priv->rx_skbuff[entry];
> >+			skb_put(rx_skb, rx_size);
> >+			skb->protocol = eth_type_trans(rx_skb, net_dev);
> 
> applied this, and the one-line fix to this
> 
Thanks Jeff, sorry again for the headache.  I'll be more careful in the future
Neil

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists