[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070428.212433.17865830.davem@davemloft.net>
Date: Sat, 28 Apr 2007 21:24:33 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jon.maloy@...csson.com
Cc: netdev@...r.kernel.org, allan.stephens@...driver.com,
jon.maloy@...jonn.com, per.liden@...csson.com
Subject: Re: [PATCH] [TIPC]: Changed msg_set_bits params type
From: Jon Paul Maloy <jon.maloy@...csson.com>
Date: Thu, 26 Apr 2007 19:50:42 -0400
> David Miller wrote:
> > Did you actually run sparse to see what warnings this change
> > adds or deletes or are you submitting untested changes?
> >
> >
> I did, and I am aware that sparse shows several warnings
> for TIPC, which we will have to fix this asap, of course.
> The patched line did not show up in the warning list, which
> along with a full regression test made me conclude that we
> didn't introduce a problem, at least. I see now that it
> didn't cause a warning before the change either, so I was
> probably too quick to try to please people. You can can
> ignore the patch if you want to, but it is safe.
Thanks for clarifying, but your email client corrupted the patch by
mangling the whitespace and adding newlines to break up long lines.
I feel like I write this to somebody every single day, but
could you please email patches to yourself and test that
they actually apply instead of wasting my time like this?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists