netdev - Re: [PATCH 1/3] [AF_IUCV/IUCV]: smp_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070428.230447.122616979.davem@davemloft.net>
Date:	Sat, 28 Apr 2007 23:04:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fpavlic@...ibm.com
Cc:	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 1/3] [AF_IUCV/IUCV]: smp_call_function deadlock

From: Frank Pavlic <fpavlic@...ibm.com>
Date: Thu, 19 Apr 2007 11:11:45 +0200

> From: Martin Schwidefsky <schwidefsky@...ibm.com>
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> From: Ursula Braun <braunu@...ibm.com>
> 
> Calling smp_call_function can lead to a deadlock if it is called
> from tasklet context. 
> Fixing this deadlock requires to move the smp_call_function from the
> tasklet context to a work queue. To do that queue the path pending
> interrupts to a separate list and move the path cleanup out of
> iucv_path_sever to iucv_path_connect and iucv_path_pending.
> This creates a new requirement for iucv_path_connect: it may not be
> called from tasklet context anymore. 
> Also fixed compile problem for CONFIG_HOTPLUG_CPU=n and
> another one when walking the cpu_online mask. When doing this, 
> we must disable cpu hotplug.
> 
> Signed-off-by: Frank Pavlic <fpavlic@...ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@...ibm.com>

Applied, except I had to kick out the HOTPLUT_CPU ifdef removal
since that was already done by f8a6d97043f9adc25889876b681998b77f543bfa

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html