netdev - Re: [PATCH 4/5 2.6.21-rc7] l2tp: pppox protocol module load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070430.002137.99458495.davem@davemloft.net>
Date:	Mon, 30 Apr 2007 00:21:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/5 2.6.21-rc7] l2tp: pppox protocol module load

From: James Chapman <jchapman@...alix.com>
Date: Mon, 23 Apr 2007 17:01:03 +0100

> [L2TP]: Add the ability to autoload a pppox protocol module.
> 
> This patch allows a name "pppox-proto-nnn" to be used in modprobe.conf
> to autoload a PPPoX protocol nnn.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>
> 
> Index: linux-2.6.21-rc7/drivers/net/pppox.c
> ===================================================================
> --- linux-2.6.21-rc7.orig/drivers/net/pppox.c
> +++ linux-2.6.21-rc7/drivers/net/pppox.c
> @@ -114,6 +114,13 @@ static int pppox_create(struct socket *s
>  		goto out;
>  
>  	rc = -EPROTONOSUPPORT;
> +#ifdef CONFIG_KMOD
> +	if (!pppox_protos[protocol]) {
> +		char buffer[32];
> +		sprintf(buffer, "pppox-proto-%d", protocol);
> +		request_module(buffer);
> +	}
> +#endif
>  	if (!pppox_protos[protocol] ||
>  	    !try_module_get(pppox_protos[protocol]->owner))
>  		goto out;

If you're going to use an interface declared in linux/kmod.h
you'll have to make sure that header file is included by
pppox.c

I've made that fix and applied your patch, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html