netdev - Re: [PATCH 2/3] ne: MIPS: Use platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070501.001426.75186152.anemo@mba.ocn.ne.jp>
Date:	Tue, 01 May 2007 00:14:26 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	akpm@...ux-foundation.org
Cc:	linux-mips@...ux-mips.org, netdev@...r.kernel.org, jeff@...zik.org,
	ralf@...ux-mips.org, sshtylyov@...mvista.com
Subject: Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

On Sun, 29 Apr 2007 02:10:37 +0900 (JST), Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
> > platform_device_register_simple() copies *res by value, so I believe we can
> > make res[] static __initdata.  This way we don't need to evaluate the array
> > on the stack at runtime, and the data gets discarded after initcalls have
> > run.
> > 
> > Can you please review and test the below?  I had a go but wasn't able to
> > fumble my way to a suitable config (I hope):
> 
> It looks OK.  I will merge your fix to updated patch.  Thank you.

Unfortunately, the RBTX4938 part can not be converted to static
__initdata since RBTX4938_RTL_8019_BASE is not a constant.

And I think the change for toshiba_rbtx4927_rtc_init() should be an
another patch.  So I will add the "static __initdata" only to
rbtx4927_ne_init().

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html