netdev - Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() & ipv6_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Apr 2007 21:08:45 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
CC:	brian.haley@...com, yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org
Subject: Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr
 to speedup ipv6_addr_equal() & ipv6_addr_any()

David Miller a écrit :
> From: Brian Haley <brian.haley@...com>
> Date: Mon, 30 Apr 2007 12:27:07 -0400
> 
>> The problem is that drivers don't necessarily align the address on the 
>> correct boundary, so on some 64-bit arches this could be fatal.  There's 
>> ways around it since I did it in a previous life, but you'd need to copy 
>> the addresses and hide them in the skb in the rare case, neither of 
>> which is a great thing to do.
> 
> Yes, the majority of the network drivers are only ensuring 32-bit
> alignment after the ethernet header currently on receive.  They
> were designed with ipv4 in mind long ago and then the logic just
> gets copied everywhere.
> 
> 

Yes I see...

Maybe we could at least define a 'struct in6_addr_k' for internal structures 
only, to speedup some parts of IPV6 stack.



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html