netdev - Re: [Bugme-new] [Bug 8405] New: pppd does stops compresion with "Lost compression sync"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705010927.52426.stefan.wenk@gmx.at>
Date:	Tue, 1 May 2007 09:27:52 +0200
From:	Stefan Wenk <stefan.wenk@....at>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Richard Purdie <rpurdie@...ys.net>, netdev@...r.kernel.org,
	"bugme-daemon@...nel-bugs.osdl.org" 
	<bugme-daemon@...zilla.kernel.org>
Subject: Re: [Bugme-new] [Bug 8405] New: pppd does stops compresion with "Lost compression sync"

> >From the commend line: `dmesg -n 8'.
>
> The really big fix is to boot with the ignore_loglevel boot option.  This
> will turn on all messages and will defeat any userspace attempt to turn the
> loglevel down.
Thanks. With this command I see also the KERN_DEBUG printks now.
>
> > Here is the full diff
>
> Thanks for persisting with this.  The problem is rather serious.
If you have instructions how to proceed I'm looking forward to help solving 
it. I guess reverting the zlib modification in the Linux main line is no 
option. What I'm wondering is that this issue hasn't been detected earlier. 
Looks as nobody is using analogue modems and nullmodem cables any more.
>
> > --- ppp_deflate.c.orig  2007-04-23 20:47:08.000000000 +0200
> > +++ ppp_deflate.c       2007-04-30 19:38:19.000000000 +0200
> > @@ -174,7 +174,7 @@ static int z_comp_init(void *arg, unsign
> >
> >         state->seqno = 0;
> >         state->unit  = unit;
> > -       state->debug = debug;
> > +       state->debug = 1;
> >
> >         zlib_deflateReset(&state->strm);
> >
> > @@ -393,7 +393,7 @@ static int z_decomp_init(void *arg, unsi
> >
> >         state->seqno = 0;
> >         state->unit  = unit;
> > -       state->debug = debug;
> > +       state->debug = 1;
> >         state->mru   = mru;
> >
> >         zlib_inflateReset(&state->strm);
> > @@ -487,12 +487,18 @@ int z_decompress(void *arg, unsigned cha
> >          */
> >         for (;;) {
> >                 r = zlib_inflate(&state->strm, Z_PACKET_FLUSH);
> > -               if (r != Z_OK) {
> > +//             if (r != Z_OK) {
> > +                if ((r != Z_OK) && (r != Z_BUF_ERROR)) {
> >                         if (state->debug)
> > -                               printk(KERN_DEBUG "z_decompress%d:
> > inflate returned %d (%s)\n",
> > +                               printk(KERN_ERR "z_decompress%d: inflate
> > returned %d (%s)\n",
> >                                        state->unit, r, (state->strm.msg?
> > state->strm.msg: ""));
> >                         return DECOMP_FATALERROR;
> >                 }
> > +                if (r == Z_BUF_ERROR) {
> > +                             printk(KERN_ERR "z_decompress%d: Would have
> > triggered an error as inflate returned %d (%s)\n",
> > +                             state->unit, r, (state->strm.msg?
> > state->strm.msg: ""));
> > +                }
>
> (that was wordwrapped).
Sorry. I should have made an attachment.
>
> What does it do?
It was just for debugging. Forget it. Now I have changed these modifications 
back, and I do not see more debug information except those below:

z_decompress0: Would have triggered an error as inflate returned -5 ()
z_decompress0: Would have triggered an error as inflate returned -5 ()
z_decompress0: Would have triggered an error as inflate returned -5 ()
..
As there are no debug logs in inflate.c I can't provide more information by 
now.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html