netdev - Re: [PATCH 2/2] NetXen: Updates for register access routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070502203146.GA17833@electric-eye.fr.zoreil.com>
Date:	Wed, 2 May 2007 22:31:46 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Mithlesh Thukral <mithlesh@...xen.com>
Cc:	netdev mailing list <netdev@...r.kernel.org>,
	netxenproj@...syssoft.com, Jeff Garzik <jeff@...zik.org>,
	rob@...xen.com
Subject: Re: [PATCH 2/2] NetXen: Updates for register access routines

Mithlesh Thukral <mithlesh@...xen.com> :
[...]
> diff --git a/drivers/net/netxen/netxen_nic.h 
> b/drivers/net/netxen/netxen_nic.h
> index ad6688e..71edb5c 100644
> --- a/drivers/net/netxen/netxen_nic.h
> +++ b/drivers/net/netxen/netxen_nic.h
> @@ -302,29 +302,28 @@ #define FLAGS_IPSEC_SA_ADD	0x04
[...]
> -#define netxen_set_cmd_desc_num_of_buff(cmd_desc, val)	\
> -	((cmd_desc)->num_of_buffers_total_length &= ~cpu_to_le32(0xff), \
> -	(cmd_desc)->num_of_buffers_total_length |= cpu_to_le32((val) & 0xff))
> -#define netxen_set_cmd_desc_totallength(cmd_desc, val)	\
> -	((cmd_desc)->num_of_buffers_total_length &= 
> ~cpu_to_le32(0xffffff00), \
> -	(cmd_desc)->num_of_buffers_total_length |= cpu_to_le32(val << 8))
> +#define netxen_set_cmd_desc_num_of_buff(cmd_desc, val)                 \
> +	((cmd_desc)->num_of_buffers_total_length &= ~(0xff<<0),         \
> +	(cmd_desc)->num_of_buffers_total_length |= (val & 0xff)<<0)

The cpu_to_leXY have disappeared but the fields of the struct are
still annotated with __le. Is sparse happy with it ?

-- 
Ueimor

Anybody got a battery for my Ultra 10 ?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html