netdev - Re: [PATCH 1/2] NetXen: Fix NetXen driver initialization on system-P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070502152711.GA28987@infradead.org>
Date:	Wed, 2 May 2007 16:27:11 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Mithlesh Thukral <mithlesh@...xen.com>
Cc:	netdev mailing list <netdev@...r.kernel.org>,
	Jeff Garzik <jeff@...zik.org>, netxenproj@...syssoft.com,
	rob@...xen.com
Subject: Re: [PATCH 1/2] NetXen: Fix NetXen driver initialization on system-P

> +#ifndef CONFIG_PPC
>  	if (pdev->class != 0x020000) {
>  		printk(KERN_ERR"NetXen function %d, class %x will not"
>  				"be enabled.\n",pci_func_id, pdev->class);
>  		return -ENODEV;
>  	}
> +#endif

This looks rather wrong.   Why would you require everyone to have
the class set to PCI_CLASS_NETWORK_ETHERNET, just not powerpc based
systems?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html