netdev - Re: 2.6.20.7 mss negotiation and path mtu discovery mostly broken?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 May 2007 16:24:20 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	bristuccia@...rentnetworks.com, "netdev" <netdev@...r.kernel.org>
Subject: Re: 2.6.20.7 mss negotiation and path mtu discovery mostly
 broken?

On Wed, 2007-04-25 at 13:16 -0700, David Miller wrote:
> From: "Ristuccia, Brian" <bristuccia@...rentnetworks.com>
> Date: Wed, 25 Apr 2007 16:11:51 -0400
> 
> > > I'm seeing a 
> > > problem where the kernel attempts to send packets with a MSS 
> > > larger than the one negotiated when the TCP connection is 
> > > established. Even after ICMP "can't fragment" messages 
> > > arrive, the kernel still attempts to increase the MSS rather 
> > > aggressively. The end result is extremely poor throughput 
> > > when sending to a network with a smaller MTU. 
> > 
> > I've tracked this problem to the TSO feature in the bnx2 driver. Turning
> > off TSO with "ethtool -K eth1 tso off" seems to work around the problem.
> > It appears that the bnx2 device is not using the correct mss when
> > performing segmentation offload. 
> 
> Thanks for narrowing it down like that.
> 
> Michael can you have a look?  Is the bnx2 firmware using the MTU
> setting in the device and ignoring the passed in MSS or something
> like that?
> 

This should fix it.  I will send this and other selected BNX2 fixes to
stable as well.  Thanks.

[BNX2]: Fix TSO problem with small MSS.

Remove the check for skb->len greater than MTU when doing TSO.  When
the destination has a smaller MSS than the source, a TSO packet may
be smaller than the MTU at the source and we still need to process it
as a TSO packet.

Thanks to Brian Ristuccia <bristuccia@...rentnetworks.com> for
reporting the problem.

Signed-off-by: Michael Chan <mchan@...adcom.com>

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 605347f..88b33c6 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4836,8 +4836,7 @@ bnx2_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		vlan_tag_flags |=
 			(TX_BD_FLAGS_VLAN_TAG | (vlan_tx_tag_get(skb) << 16));
 	}
-	if ((mss = skb_shinfo(skb)->gso_size) &&
-		(skb->len > (bp->dev->mtu + ETH_HLEN))) {
+	if ((mss = skb_shinfo(skb)->gso_size)) {
 		u32 tcp_opt_len, ip_tcp_len;
 		struct iphdr *iph;
 


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html