lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 May 2007 07:27:56 -0700 From: Jeremy Fitzhardinge <jeremy@...p.org> To: Gerd Hoffmann <kraxel@...hat.com> CC: Rusty Russell <rusty@...tcorp.com.au>, lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>, Keir Fraser <Keir.Fraser@...cam.ac.uk> Subject: Re: netfront for review Gerd Hoffmann wrote: >> Gerd, in change 11196:b85da7cd9ea5 "front: Fix rx buffer leak when >> tearing down an interface." you added a call to >> "add_id_to_freelist(np->rx_skbs, id);". However, rx_skbs doesn't have >> an extra entry for the list head, and there's never any corresponding >> get_id_from_freelist(np->rx_skbs). What should it be? > > The function has an effect in page flipping mode only. It walks the > whole list of rx skbufs (id is the loop variable ...), checks whenever > they are handed out to the frontend driver to fill in packet data and > not returned yet, and if so reclaim them ... Yes, but why use add_id_to_freelist? rx_skbs are not being used on a freelist anywhere else. It just means the rx_skb array gets filled with small integers, but the rest of the code assumes they're either NULL or an skb pointer. J - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists