netdev - Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463A7BF7.5010604@trash.net>
Date:	Fri, 04 May 2007 02:19:03 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	hadi@...erus.ca
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RESEND][PATCH][XFRM] SAD info TLV aggregation

jamal wrote:
>  enum xfrm_sadattr_type_t {
> -	XFRMA_SAD_UNSPEC,
> -	XFRMA_SADHMASK,
> -	XFRMA_SADHMAX,
> +	XFRMA_SADUNSPEC,
>  	XFRMA_SADCNT,
> +	XFRMA_SADHINFO,
>  	__XFRMA_SAD_MAX
>  
>  #define XFRMA_SAD_MAX (__XFRMA_SAD_MAX - 1)

I don't want to annoy you unnecessarily, but this still has
the same inconsistent naming (XFRMA_SAD.. vs. XFRMA_SAD_MAX),
just one spot less, which is at least confusing to remember
(as user of an API things like this also tend to make me
suspicious of its quality).

If you dont mind I'm just going to resend myself with fixed
names tomorrow so you don't have to bother doing this again.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html